TMC is an independent, primarily volunteer organization that relies on ad revenue to cover its operating costs. Please consider whitelisting TMC on your ad blocker or making a Paypal contribution here: paypal.me/SupportTMC

Album art goes from large to small

Discussion in 'Model S: User Interface' started by Merrill, Jun 25, 2013.

  1. Merrill

    Merrill Active Member

    Joined:
    Jan 23, 2013
    Messages:
    2,098
    Location:
    Sonoma, California
    Has anyone experienced the album art going from full size to small. This has happened twice, I reboot and the art come back full size. Wonder what causes this to happen
     
  2. dsm363

    dsm363 Roadster + Sig Model S

    Joined:
    May 17, 2009
    Messages:
    18,235
    Location:
    Las Vegas, NV
    I've noticed that as well. Very strange as it only happens on a few songs.
     
  3. jive_devil

    jive_devil Member

    Joined:
    Jan 3, 2012
    Messages:
    142
    Location:
    SoCal
    I've noticed the switch periodically (from large to small and back again), sometimes even over the course of a day. It's minor enough I have not spent the time trying to recreate or source the problem.
     
  4. jerry33

    jerry33 S85 - VIN:P05130 - 3/2/13

    Joined:
    Mar 8, 2012
    Messages:
    12,763
    Location:
    Texas
    It happens all the time to me. It seems to get smaller each time the list of songs cycles through, both on the small and large display. Rebooting the large display fixes the problem on both screens until the songs cycle through again. Each cycle reduces the size. As far as I can tell, it happens on all songs with album art. About 50% of the songs have no art at all and 60-70% have either no text or only partial text.
     
  5. Merrill

    Merrill Active Member

    Joined:
    Jan 23, 2013
    Messages:
    2,098
    Location:
    Sonoma, California
    I wonder what causes this to happen.
     
  6. jerry33

    jerry33 S85 - VIN:P05130 - 3/2/13

    Joined:
    Mar 8, 2012
    Messages:
    12,763
    Location:
    Texas
    Someone implemented a bad counter in a loop so it decrements the size every time.
    The missing text is because some character sets aren't supported.
     
  7. Merrill

    Merrill Active Member

    Joined:
    Jan 23, 2013
    Messages:
    2,098
    Location:
    Sonoma, California
    Jerry33, please explain.
     
  8. jerry33

    jerry33 S85 - VIN:P05130 - 3/2/13

    Joined:
    Mar 8, 2012
    Messages:
    12,763
    Location:
    Texas
    My guess is that the part that figures out the size of the artwork is in a loop rather than outside of it. The initial calculations takes the album art size and multiplies it by some calculated factor. Then when it's through one iteration of the loop, it uses the same factor to calculate a new size. So instead of looking like this:

    $factor = CALCULATEsize($albumArtRef, $song); # Here the factor gets set at the beginning and doesn't change.

    while($play = "on") {

    PLAYandDISPLAY($songListRef{ $song }, $albumArtRef, $factor);

    }

    It's:

    while($play = "on") {

    $factor = CALCULATEsize($albumArtRef, $song); # Here the factor gets changed each time through the loop.
    PLAYandDISPLAY($songListRef{ $song }, $albumArtRef, $factor);

    }

    Of course, the real code is much more complex, but the idea is there.
     
  9. hans

    hans P631

    Joined:
    Sep 27, 2012
    Messages:
    1,123
    Location:
    Menlo Park
    So the problem is the display is written in Perl ;-)
     
  10. brianman

    brianman Burrito Founder

    Joined:
    Nov 10, 2011
    Messages:
    15,487
    Hah!
     
  11. Merrill

    Merrill Active Member

    Joined:
    Jan 23, 2013
    Messages:
    2,098
    Location:
    Sonoma, California
    This seems to happen after I charge the car, then the album art is small. I reboot and everything seems to be fine til the next charge, do not know how this would relate to one another.
     

Share This Page