TMC is an independent, primarily volunteer organization that relies on ad revenue to cover its operating costs. Please consider whitelisting TMC on your ad blocker and becoming a Supporting Member. For more info: Support TMC

Open Vehicle Monitor System (OVMS) - Technical Discussion

Discussion in 'Roadster: Technical' started by markwj, Nov 1, 2011.

  1. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    Cool down will save the current charge status when it starts, and restore those settings when complete.
     
  2. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    OK. I've just committed v2.5.3 and pushed to github. I've also tagged it (as v2.5.3) and upload pre-built .hex files in the vehicle/firmware directory.

    Short story: v2.5.3 is unlikely to blow up your car, but has probably got lots of bugs, and I need your help testing to find those bugs and fix them.

    Big caveat: this is testing code, please don't use ACC if you _really_ need that charge to get to work / school / the beach / wherever. Don't blame me if your car doesn't start the charge as scheduled.

    Warning: this is a long mail.

    Firstly, the v2.5.x change log:

    Code:
    2013-09-18 2.5.3       Firmware 2.5.3
                           ## Updates to thinkcity
                           ## Remove DIAG and add ACC to V1_Production build config
                           ## Remove InternalGPS from V2_TR_Production build config, as not required
                           ## Cooldown: safety check (only recycle if charging), and revise cooldown current to 13A
                           ## Support definition of location in SMS commands
                           ## Tesla Roadster: HVAC#1 should be 0x8F not 0x87
                           ## Logging: Don't reserve a log slot if the respective logging option is disabled
                           ## Improve cooldown status reporting on SMS STAT
                           ## Tidy-up of minSOC
                           ## Move chargelimit charge stop to common vehicle.c function (not acc)
                           ## Tesla Roadster: Updates to Tom's charge-time-predictor, with thanks
                           ## Log cooldown charges as mode=5, and fix excessive-logging-bug related to cooldown cycles
                           ## Logging: Send log messages one-by-one, to avoid buffer overflows
                           ## ACC: Number homelinks from 1..3
                           ## Tesla Roadster: support for chargelimits
                           ## Make SMS "RESET" reset the module completely
                           ## Complete rework and expansion of checkpoint numbers
                           ## Stop charge after cooldown, if no subsequent charge requested
                           ## Report CAC as part of charge log record
                           ## Typos in acc for net_state_enter
                           ## Show debug checkpoint, for DIAG SMS with debugcrash
                           ## Support vehicle_fn_minutestocharge
                           ## Add a timezone parameter (-)HH:MM
                           ## ACC: Support timed charges
                           ## Move car_cooldown_wascharging to global, and make use of it in ACC
                           ## Introduce some delays to allow car to wake up
    
    2013-08-27 2.5.2       Firmware 2.5.2
                           ## Updates to vehicle_thinkcity.c (getting to a pretty usable vehicle module)
                           ## Make car_tbattery signed integer, and integrate thinkcity changes
                           ## Only report range and soc limits if >0
                           ## Merge thinkcity changes:   Think City AC-line voltage/current in SMS STAT   SMS migrated from standard handler to vehicle_thinkcity.c
                           ## Tesla Roadster: Don't stop charge after cooldown, if previously the car was already charging
                           ## Log cooldown charges that become normal charges as two separate charges
                           ## Tidy up diag, by removing temp test code T1 T2 T3
                           ## Create individual configs for TeslaRoadster and RenaultTwizy (to allow all features for these cars)
                           ## Add TRACK (type XX) vehicle that just tracks GPS
                           ## string_to_mode utility function
                           ## Rework vehicle inclusions. Tesla Roadster, Renault Twizy and Volt/Ampera are production. Everything else is experimental
                           ## Add experimental vehicle Kyburz DXP
                           ## Add HVAC message details
                           ## Support HVAC bit in car_doors5, and cooldown cycles
                           ## Range and charge limits handled by ACC
                           ## Basic ACC implementation, but without timed charges
    
    2013-08-16 2.5.1       Firmware 2.5.1
                           ## Framework to build logging module in experimental modes
                           ## FIsLatLongClose utiliy function (courtesy of Tom Saxton)
                           ## Twizy: Mi/Km conversions updated to new functions
                           ## Switch to use macros, for clarity and maintainability
                           ## ACC integration to build environment
                           ## Parameter support for base64 encoded parameters
                           ## utils support for mode display
                           ## ACC support for net_sms
                           ## Switch logging system to use new "h" historical data submission, with acknowledgement
                           ## Go from 4->6 log records, based on free space
                           ## Tesla Roadster: Notify server if charge limit is changed
                           ## Tesla Roadster: Notify server if charge mode is changed
                           ## v2.5.1 protocol guide
                           ## Add core support for cooldown
                           ## Tesla Roadster support for cooldown
                           ## Stub implementation, with basic functionality, for ACC
                           ## Zero logging records on init, plus other safety checks
                           ## Only initialise logging on a normal power up
                           ## Standardise 3 diag tests: T1, T2 and T3
                           ## Only send logging msgs if link is connected
                           ## Fix logging prefix and some logging tests
                           ## Revisions to CAR_IS_CHARGING logic
                           ## Misc bug-fixes for logging
                           ## Report distance in miles (rather than 10ths of miles)
                           ## Remove dr++ and cr++ sequence numbers, as not required
                           ## Make ACC commands case insensitive
                           ## Fix bug acknowledging log record #0
                           ## Move digital speedo feature (Tesla Roadster) from experimental to fully supported, and implement opt-in feature bits
                           ## Honour opt-in flags for logging
                           ## Only report debug crash reason if not normal power up, and only report once
    As you can see, a lot has changed. The key points are:

    • Some restructuring of the build targets:
      V1_production.hex V1 Hardware Module, production firmware
      V2_experimental.hex V2 Hardware Module, experimental firmware
      V2_production.hex V2 Hardware Module, production firmware
      V2_RT_production.hex V2 Hardware Module, Renault Twizy full firmware
      V2_TR_production.hex V2 Hardware Module, Tesla Roadster full firmware
    • Support for LOGGING (charge and drive)
    • Support for ACC (Advanced Charge Control) - Tesla Roadster only at the moment
    • Lots of other little nice fixes and enhancements

    Apart from overall reliability testing (making sure it is stable in the cars), the two things I need help with are the LOGGING and ACC functions.

    [1] Logging

    The logging code is enabled by setting opt-in feature (#13) bit 1 (to log drives) and/or bit 2 (to log charges). Or, you can just set feature #13 to 255 and opt-in to everything :)

    Once you've opted in, whenever you complete a charge or drive, the car will submit a summary record to be stored on the server. You can then use the prototype HTTP API, or perl client, to retrieve those records for your own purposes.

    Note that there is a privacy concern here, as both record types (drive and charge) store GPS locations - this is the reason why it is opt-in.

    The testing I need done is just to ensure that this works for you, and that the resulting logged drives/charges match what you are expecting. It would also be useful to confirm if this works on all supported cars (which it should).

    [2] Advanced Charge Control

    The Advanced Charge Control system is designed to supplement the (aka take over from) vehicle's own charge scheduling. It should support any vehicle with charge control, but at the moment that means only Tesla Roadster. It has some pretty sophisticated features. For the moment, it is setup via SMS, but in future we will allow smartphone Apps to do this. Once setup, it runs autonomously, and doesn't even require a cellular connection.

    ACC works from the concept of a 'charge location'. This is a geofenced location that is used for charging, and you can configure up to 4 of these (numbered #1 through #4). To define the car's current location as a 'charge location', sms "ACC HERE" to the car, and it will allocate a free slot and reply to you with it. You can use "ACC NOTHERE" to clear the current location.

    If you want to clear a particular ACC location, you can sms "ACC CLEAR n" (to clear one location), or "ACC CLEAR" (to clear all locations).

    You can show the ACC details for the current location by sms "ACC STAT" (or for a particular location by "ACC STAT n" - which is very useful if you have crappy cellular connectivity like I do).

    The ACC parameters for a particular location are configured with the "ACC PARAMS" SMS. You can list a location number (1, 2, 3 or 4) as the first parameter - or don't specify location if you just want to configure the current location the car is at. After 'ACC PARAMS", you can set the parameters you would like, from the following:

    COOLDOWN - perform a cooldown charge (13A range mode, with cooling cycles) when the car is plugged in at this ACC location
    NOCOOLDOWN - don't do a cooldown charge (default)
    HOMELINK n - activate homelink when the vehicle drives to within 100m of an ACC location (the idea is to open our garage door / gate automatically as you approach)
    NOHOMELINK - don't activate homelink (default)
    CHARGEPLUGIN - charge the car on plugin (but after cooldown, if enabled)
    CHARGEAT HH:MM - schedule charge to start at the specified time (hours:minutes, 24hour clock)
    CHARGEBY HH:MM - schedule charge to complete by the specified time (hours:minutes 24hour clock)
    NOCHARGE - don't charge (default)
    LIMIT n - limit charge current to n Amps - must be specified for all CHARGE* actions
    MODE m - set charge mode (where "m" is STA(NDARD), STO(RAGE), RAN(GE) or PER(FORMANCE)) - must be specified for all CHARGE* actions
    STOPRANGE r - stop charge when range "r" is reached (specified in vehicle units, set to 0 (default) to not limit).
    STOPSOC s - stop charge when SOC "s" is reached (specified as a percentage, set to 0 (default) to not limit).

    The actions to take at a particular ACC location must be enabled with "ACC ENABLE" (or "ACC ENABLE n") before they will work. You can also disable with "ACC DISABLE" (or "ACC DISABLE n").

    If you are using CHARGEAT or CHARGEBY, you need to specify the timezone of the vehicle. This is parameter #23 and is specified as HH:MM offset from GmT (with an optional leading "-" if west of Greenwich).

    The default temperature limit for cooldown is 31Celcius, and time limit is 60 minutes. If you want to change these, you can set parameter #15 to templimit:timelimit (e.g.; "31:60").

    Note that you can also cooldown manually, while charging, with the SMS command "COOLDOWN", and see the status with SMS "STAT".

    I've spent quite some time testing CHARGEPLUGIN, COOLDOWN, LIMIT, MODE, STOPRANGE and STOPSOC - hopefully those are ok now, but the control logic does need wider testing. I've spent almost no time testing CHARGEAT and CHARGEBY. I've also been unable to test HOMELINK and would be very interested to see if that works.

    Some notes on cooldown on Tesla Roadster

    The cooldown algorithm is to start a range mode charge at 13Amps, and to monitor the HVAC system of the car. Once the HVAC starts, runs for some time, then stops, we call it a 'cooling cycle'. We keep a record of how many such cycles have occurred.

    Once we detect that the HVAC has stopped, we try to start it again. The logic at the moment is to switch to performance mode for ten seconds, then back to range mode, once every minute until the HVAC starts again. The _best_ way of starting the HVAC is to stop and start the charge, but that is painful on the contactors, so we don't do it. Switching Range->Performance->Range seems to be the second best, but I remain unconvinced that it makes much difference. In Hong Kong summer weather, I get one cooldown cycle every ten minutes or so. I can drop 6 to 8 celcius in one hour.

    The cooldown will stop after either the desired temperature is hit (based on the temperature of the hottest brick in the battery) or the cooldown has been ongoing for the time limit.

    Conclusions

    I'm happy that the code is reasonably stable now, but really need help testing this in a larger number of cars. If you do see a problem, please get me (by eMail to OVMS developers mailing list, or my personal address):

    • Output of "SMS STAT" for the specified location
    • Your vehicle id
    • Output of base64 parameter string (from the cellphone app) - copy-and-paste
    • Date/Time you entered the ACC location (with timezone)
    • Date/Time you plugged in at the ACC location (with timezone)
    • In the smartphone app, call up the Features and Parameters screens (so the server logs those, and I can check)
    • Description of the problem you have

    Please also share success stories. It is good to know what works.

    Regards, Mark.
     
  3. Curt

    Curt Roadster Signature #55

    Joined:
    May 13, 2013
    Messages:
    408
    Location:
    Rockville, MD
    #63 Curt, Sep 22, 2013
    Last edited: Sep 22, 2013
    Mark,

    I've been trying to load v2.5.3, but with no success. I've tried

    - V2_TR_production.hex
    -
    V2_experimental.hex
    - V2_production.hex

    All result in "Error reading Hex file." error in PICkit2.

    I was able to immediately re-load v2.3.2, so I think my set-up is working correctly.

    =============
    Never mind...

    I tried again with Chrome, and now 2.5.3 loads OK. Don't know why it didn't work with Firefox.

    Testing now.

     
  4. hcsharp

    hcsharp Active Member

    Joined:
    Jun 7, 2011
    Messages:
    3,175
    Location:
    Vermont
    A few things I've noticed when the roadster is trying to cool down on its own (not with OVMS): It appears to run the HVAC until there is some pre-defined difference between the brick temp (not sure which one but I think avg) and the coolant temp. It doesn't appear to start the HVAC again until 2 conditions are met: the coolant temp comes up to match the avg brick temp, and there is almost no difference between the highest and lowest brick temps. For most of the range-mode charge it attempts to keep the temp near 25C and near the end attempts to lower it to around 15C.
     
  5. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    Interesting. I had assumed it was time based, but you may be right. I do have some logs for this and will check.
     
  6. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    #66 markwj, Oct 8, 2013
    Last edited: Oct 9, 2013
    Tesla Roadster DIAG port connectors

    Just had to look these up for someone, so thought useful to post here for reference purposes...

    Tesla Roadster DIAG port connectors and pins:

    Plug (cable side) is: mouser 571-173851-2
    and matching pins are: mouser 571-173631-1

    Socket (car side) is: mouser 571-174933-1
    and matching pins are: mouser 571-173645-1

    Note that the pins in the above links may have significant minimum order quantities. You can search mouser, using the manufacturers part number, for different packaging options, which have different quantities. In general, the cut-tape ones are easiest. I can't provide links, because mouser changes these packaging options too frequently. If you can't find what you need, let me know - OVMS tends to order pins in quantities of 1,000+ and can probably help.

    Regards, Mark.
     
  7. thefortunes

    thefortunes Member

    Joined:
    Jun 14, 2013
    Messages:
    791
    Location:
    Wisconsin
    #67 thefortunes, Oct 13, 2013
    Last edited: Oct 13, 2013
    So I just installed firmware 2.5.4 and set the ACC parameters to do a cooldown.

    I drove about 7 miles, returned (my homelink automatically worked, by the way - cool), and plugged in. Interestingly enough a cooldown starte even though the battery temp per OVMS showed 77 deg F. After 10 minutes the battery temp is now 72 deg F and cooldown is still running. Why would cooldown run when battery temp is < 88 deg F?

    My parameter #15 has an encoded value similar to parameter #16. Shouldn't this be 31:60 per the documentation (or blank)?
     
  8. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    Please try to set that parameter to 31:60. That will most likely fix your problem (the encoded value was a hangover from previous versions of firmware).
     
  9. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    Just noticed that comment. Homelink worked perfectly? So, as you drove up to your house, and it opened your gate/door automatically?

    If so, thanks for confirming that. It is a really cool feature, but we don't have homelink here so I've been unable to test it properly.
     
  10. thefortunes

    thefortunes Member

    Joined:
    Jun 14, 2013
    Messages:
    791
    Location:
    Wisconsin
    Homelink has worked twice now, perfectly.

    Re: parameter #15...I assumed that and changed it. No cooldown when I got back from the latest drive (battery temp was 70 deg F).

    I guess it doesn't matter if I'm displaying Imperial units (i.e. my battery temp was above 31 deg F and didn't trigger cooldown)?
     
  11. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    I guess if the parameter contained 'bde34...' (or something similar), it would be treated as 0:60.

    The vehicle itself works in Celcius, and temperature there should be in Celcius. When the Apps get support to manage this, we'll deal with unit conversion.
     
  12. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    Vehicle firmware v2.5.4 has been committed and pushed to github. I've also tagged it (as v2.5.4) and upload pre-built .hex files in the vehicle/firmware directory.

    Short story: v2.5.4 seems stable to me, and has most of the bugs that I know about fixed. I’m still having trouble tracking down a random charge-time-estimate bug that is affecting CHARGEBY ACC profiles, but other than that is seems fine to me.

    Big caveat: this is testing code, please don't use ACC if you _really_ need that charge to get to work / school / the beach / wherever. Don't blame me if your car doesn't start the charge as scheduled.

    Warning: this is a long mail.

    Firstly, the v2.5.x change log:

    Code:
    2013-10-11 2.5.4       Firmware 2.5.4
                           # Make MINSOC drive NET_NOTIFY_CHARGE (rather than NET_NOTIFY_STAT)
                           # Input GPIO control for input RA2..RA5, and output RC0..RC3
                           # ThinkCity: Updates to Think City support
                           # iMiev: Updates to Mitsubishi vehicle support
                           # Think City: Added support for switching on/off external heater/auxilary via Valet Mode button
                           # ACC: Aggressively stop charge if cooldown is done
                           # ACC: If we are waiting for a charge, but the charge is started, then stop it
                           # Range and SOC limits stop exactly ON the limit
                           # Think City: car_parktime added
                           # Fix for command handler with net_msg_cmd_msg
                           # Tesla Roadster: fix for mins remain estimate if SOC limit but no RANGE limit
                           # Use <=0, not ==-1, as indication range limit is not set
                           # ACC: Move old STAT command to PARAMS?, and add a new STAT command to show true status
                           # ACC: If charge is done, in acc location, and unplugged, transition to parked-in state
                           # ACC: Repeat tx charge mode and limit commands, during cooldown and acc charge, if necessary
                           # Tesla Roadster: Disable cooldown on boot
                           # ACC: Race condition for charge finishes before cooldown flag is cleared
                           # ACC: Setting params now returns a summary
                           # ACC: Reset acc state, if enable/disable or setting parameters
                           # ACC: Integer/Byte overflow workarounds
                           # ACC: Workaround race condition where charge may take a few seconds to actually start (when commanded)
                           # Tesla Roadster: Provide defaults for range, soc and cac in charge estimates
                           # Support car_chargeestimate
                           # ACC: rework to use new car_chargeestimate
     
    2013-09-18 2.5.3       Firmware 2.5.3
                           ## Updates to thinkcity
                           ## Remove DIAG and add ACC to V1_Production build config
                           ## Remove InternalGPS from V2_TR_Production build config, as not required
                           ## Cooldown: safety check (only recycle if charging), and revise cooldown current to 13A
                           ## Support definition of location in SMS commands
                           ## Tesla Roadster: HVAC#1 should be 0x8F not 0x87
                           ## Logging: Don't reserve a log slot if the respective logging option is disabled
                           ## Improve cooldown status reporting on SMS STAT
                           ## Tidy-up of minSOC
                           ## Move chargelimit charge stop to common vehicle.c function (not acc)
                           ## Tesla Roadster: Updates to Tom's charge-time-predictor, with thanks
                           ## Log cooldown charges as mode=5, and fix excessive-logging-bug related to cooldown cycles
                           ## Logging: Send log messages one-by-one, to avoid buffer overflows
                           ## ACC: Number homelinks from 1..3
                           ## Tesla Roadster: support for chargelimits
                           ## Make SMS "RESET" reset the module completely
                           ## Complete rework and expansion of checkpoint numbers
                           ## Stop charge after cooldown, if no subsequent charge requested
                           ## Report CAC as part of charge log record
                           ## Typos in acc for net_state_enter
                           ## Show debug checkpoint, for DIAG SMS with debugcrash
                           ## Support vehicle_fn_minutestocharge
                           ## Add a timezone parameter (-)HH:MM
                           ## ACC: Support timed charges
                           ## Move car_cooldown_wascharging to global, and make use of it in ACC
                           ## Introduce some delays to allow car to wake up
     
    2013-08-27 2.5.2       Firmware 2.5.2
                           ## Updates to vehicle_thinkcity.c (getting to a pretty usable vehicle module)
                           ## Make car_tbattery signed integer, and integrate thinkcity changes
                           ## Only report range and soc limits if >0
                           ## Merge thinkcity changes:   Think City AC-line voltage/current in SMS STAT   SMS migrated from standard handler to vehicle_thinkcity.c
                           ## Tesla Roadster: Don't stop charge after cooldown, if previously the car was already charging
                           ## Log cooldown charges that become normal charges as two separate charges
                           ## Tidy up diag, by removing temp test code T1 T2 T3
                           ## Create individual configs for TeslaRoadster and RenaultTwizy (to allow all features for these cars)
                           ## Add TRACK (type XX) vehicle that just tracks GPS
                           ## string_to_mode utility function
                           ## Rework vehicle inclusions. Tesla Roadster, Renault Twizy and Volt/Ampera are production. Everything else is experimental
                           ## Add experimental vehicle Kyburz DXP
                           ## Add HVAC message details
                           ## Support HVAC bit in car_doors5, and cooldown cycles
                           ## Range and charge limits handled by ACC
                           ## Basic ACC implementation, but without timed charges
     
    2013-08-16 2.5.1       Firmware 2.5.1
                           ## Framework to build logging module in experimental modes
                           ## FIsLatLongClose utiliy function (courtesy of Tom Saxton)
                           ## Twizy: Mi/Km conversions updated to new functions
                           ## Switch to use macros, for clarity and maintainability
                           ## ACC integration to build environment
                           ## Parameter support for base64 encoded parameters
                           ## utils support for mode display
                           ## ACC support for net_sms
                           ## Switch logging system to use new "h" historical data submission, with acknowledgement
                           ## Go from 4->6 log records, based on free space
                           ## Tesla Roadster: Notify server if charge limit is changed
                           ## Tesla Roadster: Notify server if charge mode is changed
                           ## v2.5.1 protocol guide
                           ## Add core support for cooldown
                           ## Tesla Roadster support for cooldown
                           ## Stub implementation, with basic functionality, for ACC
                           ## Zero logging records on init, plus other safety checks
                           ## Only initialise logging on a normal power up
                           ## Standardise 3 diag tests: T1, T2 and T3
                           ## Only send logging msgs if link is connected
                           ## Fix logging prefix and some logging tests
                           ## Revisions to CAR_IS_CHARGING logic
                           ## Misc bug-fixes for logging
                           ## Report distance in miles (rather than 10ths of miles)
                           ## Remove dr++ and cr++ sequence numbers, as not required
                           ## Make ACC commands case insensitive
                           ## Fix bug acknowledging log record #0
                           ## Move digital speedo feature (Tesla Roadster) from experimental to fully supported, and implement opt-in feature bits
                           ## Honour opt-in flags for logging
                           ## Only report debug crash reason if not normal power up, and only report once
    As you can see, a lot has changed. The key points are:

    • Some restructuring of the build targets:
      V1_production.hex V1 Hardware Module, production firmware
      V2_experimental.hex V2 Hardware Module, experimental firmware
      V2_production.hex V2 Hardware Module, production firmware
      V2_RT_production.hex V2 Hardware Module, Renault Twizy full firmware
      V2_TR_production.hex V2 Hardware Module, Tesla Roadster full firmware
    • Support for LOGGING (charge and drive)
    • Support for ACC (Advanced Charge Control) - Tesla Roadster only at the moment
    • Lots of other little nice fixes and enhancements

    Apart from overall reliability testing (making sure it is stable in the cars), the two things I need help with are the LOGGING and ACC functions.

    [1] Logging

    The logging code is enabled by setting opt-in feature (#13) bit 1 (to log drives) and/or bit 2 (to log charges). Or, you can just set feature #13 to 255 and opt-in to everything :)

    Once you've opted in, whenever you complete a charge or drive, the car will submit a summary record to be stored on the server. You can then use the prototype HTTP API, or perl client, to retrieve those records for your own purposes.

    Note that there is a privacy concern here, as both record types (drive and charge) store GPS locations - this is the reason why it is opt-in.

    The testing I need done is just to ensure that this works for you, and that the resulting logged drives/charges match what you are expecting. It would also be useful to confirm if this works on all supported cars (which it should).

    [2] Advanced Charge Control

    The Advanced Charge Control system is designed to supplement the (aka take over from) vehicle's own charge scheduling. It should support any vehicle with charge control, but at the moment that means only Tesla Roadster. It has some pretty sophisticated features. For the moment, it is setup via SMS, but in future we will allow smartphone Apps to do this. Once setup, it runs autonomously, and doesn't even require a cellular connection.

    ACC works from the concept of a 'charge location'. This is a geofenced location that is used for charging, and you can configure up to 4 of these (numbered #1 through #4). To define the car's current location as a 'charge location', sms "ACC HERE" to the car, and it will allocate a free slot and reply to you with it. You can use "ACC NOTHERE" to clear the current location.

    If you want to clear a particular ACC location, you can sms "ACC CLEAR n" (to clear one location), or "ACC CLEAR" (to clear all locations).

    You can show the current status off ACC with “ACC STAT”.

    You can show the ACC details for the current location by sms "ACC PARAMS?" (or for a particular location by "ACC PARAMS? n" - which is very useful if you have crappy cellular connectivity like I do).

    The ACC parameters for a particular location are configured with the "ACC PARAMS" SMS. You can list a location number (1, 2, 3 or 4) as the first parameter - or don't specify location if you just want to configure the current location the car is at. After 'ACC PARAMS", you can set the parameters you would like, from the following:

    • COOLDOWN - perform a cooldown charge (13A range mode, with cooling cycles) when the car is plugged in at this ACC location
    • NOCOOLDOWN - don't do a cooldown charge (default)
    • HOMELINK n - activate homelink when the vehicle drives to within 100m of an ACC location (the idea is to open our garage door / gate automatically as you approach)
    • NOHOMELINK - don't activate homelink (default)
    • CHARGEPLUGIN - charge the car on plugin (but after cooldown, if enabled)
    • CHARGEAT HH:MM - schedule charge to start at the specified time (hours:minutes, 24hour clock)
    • CHARGEBY HH:MM - schedule charge to complete by the specified time (hours:minutes 24hour clock)
    • NOCHARGE - don't charge (default)
    • LIMIT n - limit charge current to n Amps - must be specified for all CHARGE* actions
    • MODE m - set charge mode (where "m" is STA(NDARD), STO(RAGE), RAN(GE) or PER(FORMANCE)) - must be specified for all CHARGE* actions
    • STOPRANGE r - stop charge when range "r" is reached (specified in vehicle units, set to 0 (default) to not limit).
    • STOPSOC s - stop charge when SOC "s" is reached (specified as a percentage, set to 0 (default) to not limit).

    The actions to take at a particular ACC location must be enabled with "ACC ENABLE" (or "ACC ENABLE n") before they will work. You can also disable with "ACC DISABLE" (or "ACC DISABLE n").

    If you are using CHARGEAT or CHARGEBY, you need to specify the timezone of the vehicle. This is parameter #23 and is specified as HH:MM offset from GmT (with an optional leading "-" if west of Greenwich).

    The default temperature limit for cooldown is 31Celcius, and time limit is 60 minutes. If you want to change these, you can set parameter #15 to templimit:timelimit (e.g.; "31:60").

    Note that you can also cooldown manually, while charging, with the SMS command "COOLDOWN", and see the status with SMS "STAT".

    I've spent quite some time testing CHARGEPLUGIN, CHARGEAT, COOLDOWN, LIMIT, MODE, STOPRANGE and STOPSOC - hopefully those are ok now, but the control logic does need wider testing. The CHARGEBY option is still giving me random problems, related to the charge time estimated - I am still working on that. I've also been unable to test HOMELINK and would be very interested to see if that works.

    Some notes on cooldown on Tesla Roadster

    The cooldown algorithm is to start a range mode charge at 13Amps, and to monitor the HVAC system of the car. Once the HVAC starts, runs for some time, then stops, we call it a 'cooling cycle'. We keep a record of how many such cycles have occurred.

    Once we detect that the HVAC has stopped, we try to start it again. The logic at the moment is to switch to performance mode for ten seconds, then back to range mode, once every minute until the HVAC starts again. The _best_ way of starting the HVAC is to stop and start the charge, but that is painful on the contactors, so we don't do it. Switching Range->Performance->Range seems to be the second best, but I remain unconvinced that it makes much difference. In Hong Kong summer weather, I get one cooldown cycle every ten minutes or so. I can drop 6 to 8 celcius in one hour.

    The cooldown will stop after either the desired temperature is hit (based on the temperature of the hottest brick in the battery) or the cooldown has been ongoing for the time limit.

    Conclusions

    I'm happy that the code is reasonably stable now, but really need help testing this in a larger number of cars. If you do see a problem, please get me (by eMail to OVMS developers mailing list, or my personal address):

    • Output of "SMS STAT" for the specified location
    • Your vehicle id
    • Output of base64 parameter string (from the cellphone app) - copy-and-paste
    • Date/Time you entered the ACC location (with timezone)
    • Date/Time you plugged in at the ACC location (with timezone)
    • In the smartphone app, call up the Features and Parameters screens (so the server logs those, and I can check)
    • Description of the problem you have

    Please also share success stories. It is good to know what works.
     
  13. asgard

    asgard Member

    Joined:
    Aug 17, 2013
    Messages:
    310
    Location:
    CA
    I installed 2.5.4 last evening. So far looks very stable. I have not tried a cool down yet but ACC is working fine for a timed charge.

    I have a 1.5 Roadster....should I worry about the battery drain on the 12v battery caused by OVMS?
    Anyone know the drain current of the OVMS box?
     
  14. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    No worry that I know of. 1.5s don't even have a 12V battery, and OVMS is not powered by the 12V battery in the 2.x cars.
     
  15. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    OK. I've just committed v2.5.5 and pushed to github. I've also tagged it (as v2.5.5) and upload pre-built .hex files in the vehicle/firmware directory.

    Short story: v2.5.5 seems stable to me, and has most of the bugs that I know about fixed.

    Caveats: None

    Warning: this is a long mail.

    Firstly, the v2.5.x change log:

    Code:
    2013-11-28 2.5.5       Firmware 2.5.5
                           # Fix mode numnbers for display of range and performance charge modes
                           # V1_TeslaRoadster config: include logging, but no room for ACC
                           # TeslaRoadster: CTP prediction based on charge limit, not current current
                           # ACC: Use car_chargesubstate!=0x07 instead of pilot signal
                           # Add TEMPS SMS command for temperatures
                           # ACC: Delay CTP calculations until acc charge mode is stable
                           # ACC: Remove 30 minute safety margin for CHARGEBY
                           # Config changes to optimise what is in each config
    
    2013-10-11 2.5.4       Firmware 2.5.4
                           # Make MINSOC drive NET_NOTIFY_CHARGE (rather than NET_NOTIFY_STAT)
                           # Input GPIO control for input RA2..RA5, and output RC0..RC3
                           # ThinkCity: Updates to Think City support
                           # iMiev: Updates to Mitsubishi vehicle support
                           # Think City: Added support for switching on/off external heater/auxilary via Valet Mode button
                           # ACC: Aggressively stop charge if cooldown is done
                           # ACC: If we are waiting for a charge, but the charge is started, then stop it
                           # Range and SOC limits stop exactly ON the limit
                           # Think City: car_parktime added
                           # Fix for command handler with net_msg_cmd_msg
                           # Tesla Roadster: fix for mins remain estimate if SOC limit but no RANGE limit
                           # Use <=0, not ==-1, as indication range limit is not set
                           # ACC: Move old STAT command to PARAMS?, and add a new STAT command to show true status
                           # ACC: If charge is done, in acc location, and unplugged, transition to parked-in state
                           # ACC: Repeat tx charge mode and limit commands, during cooldown and acc charge, if necessary
                           # Tesla Roadster: Disable cooldown on boot
                           # ACC: Race condition for charge finishes before cooldown flag is cleared
                           # ACC: Setting params now returns a summary
                           # ACC: Reset acc state, if enable/disable or setting parameters
                           # ACC: Integer/Byte overflow workarounds
                           # ACC: Workaround race condition where charge may take a few seconds to actually start (when commanded)
                           # Tesla Roadster: Provide defaults for range, soc and cac in charge estimates
                           # Support car_chargeestimate
                           # ACC: rework to use new car_chargeestimate
    
    2013-09-18 2.5.3       Firmware 2.5.3
                           ## Updates to thinkcity
                           ## Remove DIAG and add ACC to V1_Production build config
                           ## Remove InternalGPS from V2_TR_Production build config, as not required
                           ## Cooldown: safety check (only recycle if charging), and revise cooldown current to 13A
                           ## Support definition of location in SMS commands
                           ## Tesla Roadster: HVAC#1 should be 0x8F not 0x87
                           ## Logging: Don't reserve a log slot if the respective logging option is disabled
                           ## Improve cooldown status reporting on SMS STAT
                           ## Tidy-up of minSOC
                           ## Move chargelimit charge stop to common vehicle.c function (not acc)
                           ## Tesla Roadster: Updates to Tom's charge-time-predictor, with thanks
                           ## Log cooldown charges as mode=5, and fix excessive-logging-bug related to cooldown cycles
                           ## Logging: Send log messages one-by-one, to avoid buffer overflows
                           ## ACC: Number homelinks from 1..3
                           ## Tesla Roadster: support for chargelimits
                           ## Make SMS "RESET" reset the module completely
                           ## Complete rework and expansion of checkpoint numbers
                           ## Stop charge after cooldown, if no subsequent charge requested
                           ## Report CAC as part of charge log record
                           ## Typos in acc for net_state_enter
                           ## Show debug checkpoint, for DIAG SMS with debugcrash
                           ## Support vehicle_fn_minutestocharge
                           ## Add a timezone parameter (-)HH:MM
                           ## ACC: Support timed charges
                           ## Move car_cooldown_wascharging to global, and make use of it in ACC
                           ## Introduce some delays to allow car to wake up
    
    2013-08-27 2.5.2       Firmware 2.5.2
                           ## Updates to vehicle_thinkcity.c (getting to a pretty usable vehicle module)
                           ## Make car_tbattery signed integer, and integrate thinkcity changes
                           ## Only report range and soc limits if >0
                           ## Merge thinkcity changes:   Think City AC-line voltage/current in SMS STAT   SMS migrated from standard handler to vehicle_thinkcity.c
                           ## Tesla Roadster: Don't stop charge after cooldown, if previously the car was already charging
                           ## Log cooldown charges that become normal charges as two separate charges
                           ## Tidy up diag, by removing temp test code T1 T2 T3
                           ## Create individual configs for TeslaRoadster and RenaultTwizy (to allow all features for these cars)
                           ## Add TRACK (type XX) vehicle that just tracks GPS
                           ## string_to_mode utility function
                           ## Rework vehicle inclusions. Tesla Roadster, Renault Twizy and Volt/Ampera are production. Everything else is experimental
                           ## Add experimental vehicle Kyburz DXP
                           ## Add HVAC message details
                           ## Support HVAC bit in car_doors5, and cooldown cycles
                           ## Range and charge limits handled by ACC
                           ## Basic ACC implementation, but without timed charges
    
    2013-08-16 2.5.1       Firmware 2.5.1
                           ## Framework to build logging module in experimental modes
                           ## FIsLatLongClose utiliy function (courtesy of Tom Saxton)
                           ## Twizy: Mi/Km conversions updated to new functions
                           ## Switch to use macros, for clarity and maintainability
                           ## ACC integration to build environment
                           ## Parameter support for base64 encoded parameters
                           ## utils support for mode display
                           ## ACC support for net_sms
                           ## Switch logging system to use new "h" historical data submission, with acknowledgement
                           ## Go from 4->6 log records, based on free space
                           ## Tesla Roadster: Notify server if charge limit is changed
                           ## Tesla Roadster: Notify server if charge mode is changed
                           ## v2.5.1 protocol guide
                           ## Add core support for cooldown
                           ## Tesla Roadster support for cooldown
                           ## Stub implementation, with basic functionality, for ACC
                           ## Zero logging records on init, plus other safety checks
                           ## Only initialise logging on a normal power up
                           ## Standardise 3 diag tests: T1, T2 and T3
                           ## Only send logging msgs if link is connected
                           ## Fix logging prefix and some logging tests
                           ## Revisions to CAR_IS_CHARGING logic
                           ## Misc bug-fixes for logging
                           ## Report distance in miles (rather than 10ths of miles)
                           ## Remove dr++ and cr++ sequence numbers, as not required
                           ## Make ACC commands case insensitive
                           ## Fix bug acknowledging log record #0
                           ## Move digital speedo feature (Tesla Roadster) from experimental to fully supported, and implement opt-in feature bits
                           ## Honour opt-in flags for logging
                           ## Only report debug crash reason if not normal power up, and only report once
    As you can see, a lot has changed. The key points are:

    • Some restructuring of the build targets:
    • V1_production.hex V1 Hardware Module, production firmware
    • V2_experimental.hex V2 Hardware Module, experimental firmware
    • V2_production.hex V2 Hardware Module, production firmware
    • V2_RT_production.hex V2 Hardware Module, Renault Twizy full firmware
    • V2_TR_production.hex V2 Hardware Module, Tesla Roadster full firmware
    • Support for LOGGING (charge and drive)
    • Support for ACC (Advanced Charge Control) - Tesla Roadster v2 modules only at the moment
    • Lots of other little nice fixes and enhancements

    Apart from overall reliability testing (making sure it is stable in the cars), the two things I need help with are the LOGGING and ACC functions.

    [1] Logging

    The logging code is enabled by setting opt-in feature (#13) bit 1 (to log drives) and/or bit 2 (to log charges). Or, you can just set feature #13 to 255 and opt-in to everything :)

    Once you've opted in, whenever you complete a charge or drive, the car will submit a summary record to be stored on the server. You can then use the prototype HTTP API, or perl client, to retrieve those records for your own purposes.

    Note that there is a privacy concern here, as both record types (drive and charge) store GPS locations - this is the reason why it is opt-in.

    The testing I need done is just to ensure that this works for you, and that the resulting logged drives/charges match what you are expecting. It would also be useful to confirm if this works on all supported cars (which it should).

    [2] Advanced Charge Control

    The Advanced Charge Control system is designed to supplement the (aka take over from) vehicle's own charge scheduling. It should support any vehicle with charge control, but at the moment that means only Tesla Roadster. It has some pretty sophisticated features. For the moment, it is setup via SMS, but in future we will allow smartphone Apps to do this. Once setup, it runs autonomously, and doesn't even require a cellular connection.

    ACC works from the concept of a 'charge location'. This is a geofenced location that is used for charging, and you can configure up to 4 of these (numbered #1 through #4). To define the car's current location as a 'charge location', sms "ACC HERE" to the car, and it will allocate a free slot and reply to you with it. You can use "ACC NOTHERE" to clear the current location.

    If you want to clear a particular ACC location, you can sms "ACC CLEAR n" (to clear one location), or "ACC CLEAR" (to clear all locations).

    You can show the current status off ACC with “ACC STAT”.

    You can show the ACC details for the current location by sms "ACC PARAMS?" (or for a particular location by "ACC PARAMS? n" - which is very useful if you have crappy cellular connectivity like I do).

    The ACC parameters for a particular location are configured with the "ACC PARAMS" SMS. You can list a location number (1, 2, 3 or 4) as the first parameter - or don't specify location if you just want to configure the current location the car is at. After 'ACC PARAMS", you can set the parameters you would like, from the following:

    • COOLDOWN - perform a cooldown charge (13A range mode, with cooling cycles) when the car is plugged in at this ACC location
    • NOCOOLDOWN - don't do a cooldown charge (default)
    • HOMELINK n - activate homelink when the vehicle drives to within 100m of an ACC location (the idea is to open our garage door / gate automatically as you approach)
    • NOHOMELINK - don't activate homelink (default)
    • CHARGEPLUGIN - charge the car on plugin (but after cooldown, if enabled)
    • CHARGEAT HH:MM - schedule charge to start at the specified time (hours:minutes, 24hour clock)
    • CHARGEBY HH:MM - schedule charge to complete by the specified time (hours:minutes 24hour clock)
    • NOCHARGE - don't charge (default)
    • LIMIT n - limit charge current to n Amps - must be specified for all CHARGE* actions
    • MODE m - set charge mode (where "m" is STA(NDARD), STO(RAGE), RAN(GE) or PER(FORMANCE)) - must be specified for all CHARGE* actions
    • STOPRANGE r - stop charge when range "r" is reached (specified in vehicle units, set to 0 (default) to not limit).
    • STOPSOC s - stop charge when SOC "s" is reached (specified as a percentage, set to 0 (default) to not limit).

    The actions to take at a particular ACC location must be enabled with "ACC ENABLE" (or "ACC ENABLE n") before they will work. You can also disable with "ACC DISABLE" (or "ACC DISABLE n").

    If you are using CHARGEAT or CHARGEBY, you need to specify the timezone of the vehicle. This is parameter #23 and is specified as HH:MM offset from GmT (with an optional leading "-" if west of Greenwich).

    The default temperature limit for cooldown is 31Celcius, and time limit is 60 minutes. If you want to change these, you can set parameter #15 to templimit:timelimit (e.g.; "31:60").

    Note that you can also cooldown manually, while charging, with the SMS command "COOLDOWN", and see the status with SMS "STAT".

    I've spent quite some time testing CHARGEPLUGIN, CHARGEAT, COOLDOWN, LIMIT, MODE, STOPRANGE and STOPSOC - hopefully those are ok now, but the control logic does need wider testing. The CHARGEBY option is still giving me random problems, related to the charge time estimated - I am still working on that. I've also been unable to test HOMELINK and would be very interested to see if that works.

    Some notes on cooldown on Tesla Roadster

    The cooldown algorithm is to start a range mode charge at 13Amps, and to monitor the HVAC system of the car. Once the HVAC starts, runs for some time, then stops, we call it a 'cooling cycle'. We keep a record of how many such cycles have occurred.

    Once we detect that the HVAC has stopped, we try to start it again. The logic at the moment is to switch to performance mode for ten seconds, then back to range mode, once every minute until the HVAC starts again. The _best_ way of starting the HVAC is to stop and start the charge, but that is painful on the contactors, so we don't do it. Switching Range->Performance->Range seems to be the second best, but I remain unconvinced that it makes much difference. In Hong Kong summer weather, I get one cooldown cycle every ten minutes or so. I can drop 6 to 8 celcius in one hour.

    The cooldown will stop after either the desired temperature is hit (based on the temperature of the hottest brick in the battery) or the cooldown has been ongoing for the time limit.

    Conclusions

    This is the firmware I would like to include in the next batch of v2 modules coming from the factory. So, I would appreciate it if you guys could test what you can and let me have your feedback.

    Regards, Mark.
     
  16. blavenn

    blavenn Member

    Joined:
    Dec 10, 2012
    Messages:
    44
    Location:
    Miami
    Very nice, great work Mark!
     
  17. thefortunes

    thefortunes Member

    Joined:
    Jun 14, 2013
    Messages:
    791
    Location:
    Wisconsin
    I've been using 2.5.4 for a couple weeks now (no cooldowns required here in the great white north anymore so hard to know how well it works). My only negative feedback is on Homelink...

    The Homelink signal is so strong that it can trigger my garage door from around the street corner (apparently in the gap between houses before the house on the corner). I assume the corner house then blocks the signal for a couple seconds because when I turn the corner (and thus have cleared the house on the corner) Homelink appears to still be sending and ends up stopping the garage door mid-opening. This only happens if I come down the street 90 degrees from my street, if I come straight down my street it doesn't trigger "twice." Probably nothing you can do.
     
  18. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    Making the trigger rangers for account locations adjustable might help?
     
  19. thefortunes

    thefortunes Member

    Joined:
    Jun 14, 2013
    Messages:
    791
    Location:
    Wisconsin
    It would. If I set it for 50m instead of 100m, for example, it wouldn't trigger until I was around the corner (I think).

    Actually, 50m might be a better fixed range anyway - when I turned the auto on I was concerned that from 100m down the street I may not be able to see the door. If a garage door was already open and someone was unloading groceries, for example, the door could come down on the trunk/hatch before I could reverse it.
     
  20. markwj

    markwj Moderator, Asia Pacific

    Joined:
    Apr 10, 2011
    Messages:
    4,279
    Location:
    Hong Kong
    I'll put the ranges as a configurable feature in the next version, so you can try to tune it.

    Now that the Selective Availability BS is gone from GPS, it is pretty accurate. +/- 20m should be easily achievable.
     

Share This Page

  • About Us

    Formed in 2006, Tesla Motors Club (TMC) was the first independent online Tesla community. Today it remains the largest and most dynamic community of Tesla enthusiasts. Learn more.
  • Do you value your experience at TMC? Consider becoming a Supporting Member of Tesla Motors Club. As a thank you for your contribution, you'll get nearly no ads in the Community and Groups sections. Additional perks are available depending on the level of contribution. Please visit the Account Upgrades page for more details.


    SUPPORT TMC