Agreed, seven years was the simple payback ignoring the time value of money or taxes. The IRR of these (-32000,4500,4500 (for twenty years)) cashflows is 12.8%. That is pretax. And I am ignoring the fact that in 2035 I wills till have the panels and can switch to net metering from that point forward. Assuming that my daytime rate is $0.20/kWh and some degradation then I will be able to offset $2000 per year from 2035 onwards with net metering - that means I will reduce my power used by using my own power. I will have to have system rewired at that point as right now my power produced goes to a separate meter and back to the grid. Under net metering it will flow through the same meter.
The income is taxable but you do have depreciation (AKA CCA) and you can offset expenses against this. And you could have borrowed money and the interest would be tax deductible, or would offset the income from the panels.
The panels do degrade over time but the degradation does not appear to have been that appreciable - you will notice from the graph above that I just had my best September ever. It would be interesting to download the amount of sun that Toronto received in Sep 2023 and compare it to other years to see how much my panels would have produced this year if there had been no degradation. Estimates are that panels degrade from 0.5%-3% per year.