Based on my current understanding, here are the pros and cons right now:
Pros:
1) The solar shingles look fantastic. Far better than anything I've ever seen before. They knocked this one out of the park.
2) Powerwall 2. Stats look great. Better load, bigger battery, integrated inverter, looks good. Pricing-wise, looks like a better deal than Powerwall 1.
3) The Tesla merger. Maybe just my opinion, but I feel a lot better with the idea of solar from Tesla/SolarCity than just solar from SolarCity. Among other things, it might greatly accelerate how quickly the tech becomes available in places it previously wasn't.
Cons:
1) Looks like it's got a ways to go yet before it's market ready, in terms of both product maturity and regulations.
2) Solar panel density. The fantastic aesthetics of the panels noticeably impacts panel density. And based on what I've read, they will still need the same set backs as traditional rooftop solar, so they lose a potential advantage there I thought they would have. I was hoping you might be able to get more solar on your roof with these as compared to traditional rooftop solar, but now I think it will actually be less.
3) Only good for houses needing new roofs.
4) General lack of information. There are still many unknowns.